Skip to content

Issue-2002 (wrong calculation of pre-release version)#2003

Merged
asbjornu merged 3 commits into
GitTools:masterfrom
pi3k14:issue-2002
Jan 3, 2020
Merged

Issue-2002 (wrong calculation of pre-release version)#2003
asbjornu merged 3 commits into
GitTools:masterfrom
pi3k14:issue-2002

Conversation

@pi3k14

@pi3k14 pi3k14 commented Dec 20, 2019 •
edited by asbjornu
Loading

Copy link
Copy Markdown

Created unit test

using var fixture = new EmptyRepositoryFixture();
fixture.Repository.MakeACommit();
fixture.BranchTo("develop");
fixture.MakeATaggedCommit("1.0.0-alpha.3"); // manual bump version
fixture.MakeACommit();
fixture.MakeACommit();
fixture.AssertFullSemver("1.0.0-alpha.5");

Fixes #2002.

@pi3k14 pi3k14 mentioned this pull request Dec 30, 2019
Closed
This was referenced Jan 3, 2020
Open
Closed
Closed
Closed
Closed
@asbjornu asbjornu merged commit 5ba22ae into GitTools:master Jan 3, 2020
@asbjornu

asbjornu commented Jan 3, 2020

Copy link
Copy Markdown
Member

Thank you so much for your contributions, @pi3k14! 🙏

@jetersen

jetersen commented Jan 3, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

I would love to test the prerelase, yet publish failed: https://dev.azure.com/GitTools/GitVersion/_build/results?buildId=1595&view=results
Edit: seems like it managed to publish anyhow

@arturcic arturcic added this to the 5.1.4 milestone Jan 7, 2020
@arturcic arturcic added the bug label Jan 7, 2020
@asbjornu asbjornu mentioned this pull request Jan 15, 2020
Closed
@pi3k14 pi3k14 deleted the issue-2002 branch February 4, 2020 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asbjornu asbjornu asbjornu approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

5.2.0

Development

Successfully merging this pull request may close these issues.

Wrong calculation of pre-release when develop tagged

4 participants

@pi3k14 @asbjornu @jetersen @arturcic