Skip to content

fix: print twice same point#777

Merged
BilelJegham merged 6 commits intomasterfrom
fix/same-point
Jun 28, 2024
Merged

fix: print twice same point#777
BilelJegham merged 6 commits intomasterfrom
fix/same-point

Conversation

@BilelJegham
Copy link
Copy Markdown
Member

@BilelJegham BilelJegham commented Jun 19, 2024

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description

  • Issue when you play on the same map
  • Optimise Geojson from openstreetmap
  • rework Multiplayer loading between round

How Has This Been Tested?

Launch 2 games with map set on "France"

Screenshots (if appropriate):

@BilelJegham BilelJegham marked this pull request as draft June 19, 2024 18:10
@cypress
Copy link
Copy Markdown

cypress bot commented Jun 19, 2024

Passing run #762 ↗︎

0 7 0 0 Flakiness 0

Details:

fix: print twice same point (#777)
Project: GeoGuess Commit: 406a4b9b9c
Status: Passed Duration: 02:15 💡
Started: Jun 28, 2024 4:18 PM Ended: Jun 28, 2024 4:20 PM

Review all test suite changes for PR #777 ↗︎

@BilelJegham BilelJegham marked this pull request as ready for review June 28, 2024 15:34
@netlify
Copy link
Copy Markdown

netlify bot commented Jun 28, 2024

Deploy Preview for geoguess2 ready!

Name Link
🔨 Latest commit eb06971
🔍 Latest deploy log https://app.netlify.com/sites/geoguess2/deploys/667edb1738fb880008b8e7f5
😎 Deploy Preview https://deploy-preview-777--geoguess2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarqubecloud
Copy link
Copy Markdown

@BilelJegham BilelJegham added this pull request to the merge queue Jun 28, 2024
Merged via the queue into master with commit 406a4b9 Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant