Fix a bug reporting incorrect number of consensus peaks on the terminal#181
Merged
VJalili merged 2 commits intoGenometric:devfrom Nov 15, 2022
Merged
Fix a bug reporting incorrect number of consensus peaks on the terminal#181VJalili merged 2 commits intoGenometric:devfrom
VJalili merged 2 commits intoGenometric:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #181 +/- ##
=======================================
Coverage 97.52% 97.52%
=======================================
Files 43 43
Lines 2178 2178
=======================================
Hits 2124 2124
Misses 10 10
Partials 44 44 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where MSPC is not reporting a correct number of the identified consensus peaks on the terminal. The issue is related to the recently added stranded analysis (#176), where MSPC wrote in the terminal the number of strands instead of the peak count for consensus peaks.
This PR adds a unit test to reproduce the issue and fixes the bug.
Thanks to @MeriemBahda for reporting this bug!