Add tests for grdfilter#809
Merged
seisman merged 16 commits intoGenericMappingTools:masterfrom Jan 30, 2021
Merged
Conversation
Member
|
@willschlitzer Just a quick comment. When opening a PR, please use the PR template, so we can have the PR checklist. |
Contributor
Author
|
@seisman Sorry about that. |
seisman
reviewed
Jan 28, 2021
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Fix comment
seisman
reviewed
Jan 28, 2021
Member
|
It would be better if you can add two more checks:
|
Contributor
Author
|
@seisman Added the two additional tests. |
seisman
reviewed
Jan 28, 2021
seisman
reviewed
Jan 28, 2021
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
Jan 28, 2021
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
approved these changes
Jan 28, 2021
Member
seisman
left a comment
There was a problem hiding this comment.
This PR looks good to me.
I'll keep this PR unmerged for two more days so that @GenericMappingTools/python @GenericMappingTools/python-maintainers can give it a final review.
5 tasks
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds tests for the
grdfilterfunction ingrdops.py.Reminders
make formatandmake checkto make sure the code follows the style guide.Notes
/formatin the first line of a comment to lint the code automatically