Skip to content

Allow anyone to run the /format command in PRs#768

Merged
seisman merged 2 commits intomasterfrom
fix-slash-dispatch
Dec 27, 2020
Merged

Allow anyone to run the /format command in PRs#768
seisman merged 2 commits intomasterfrom
fix-slash-dispatch

Conversation

@seisman
Copy link
Member

@seisman seisman commented Dec 27, 2020

Description of proposed changes

The default permission is write and only the maintainers can run the slash
dispatch commands. This PR fixes the permission to none.

Fixes #767.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Notes

  • You can write /format in the first line of a comment to lint the code automatically

@seisman seisman added the maintenance Boring but important stuff for the core devs label Dec 27, 2020
@seisman seisman added this to the 0.3.0 milestone Dec 27, 2020
@seisman seisman requested a review from weiji14 December 27, 2020 00:49
@seisman seisman added bug Something isn't working skip-changelog Skip adding Pull Request to changelog waiting for review labels Dec 27, 2020
@seisman seisman merged commit 5ad636b into master Dec 27, 2020
@seisman seisman deleted the fix-slash-dispatch branch December 27, 2020 22:36
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slash command "/format" doesn't work for external contributors

2 participants