Skip to content

Add a table for compatibility of PyGMT with Python and GMT#763

Merged
seisman merged 4 commits intomasterfrom
compatibility
Dec 29, 2020
Merged

Add a table for compatibility of PyGMT with Python and GMT#763
seisman merged 4 commits intomasterfrom
compatibility

Conversation

@seisman
Copy link
Member

@seisman seisman commented Dec 25, 2020

Description of proposed changes

Fixes #748.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Notes

  • You can write /format in the first line of a comment to lint the code automatically

@seisman seisman added the maintenance Boring but important stuff for the core devs label Dec 25, 2020
@seisman seisman added this to the 0.3.0 milestone Dec 25, 2020
@seisman seisman requested a review from weiji14 December 25, 2020 01:21

======= ========== =========
PyGMT GMT Python
======= ========== =========
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add the 0.3.0 entry now or later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add it later, not too sure yet when we want to cut a 0.3.0 release?

Copy link
Member Author

@seisman seisman Dec 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can release v0.3.0 two weeks before GMT v6.2.0 (late Jan or early Feb).

README.rst Outdated
======= ========== =========
PyGMT GMT Python
======= ========== =========
0.2.1 >=6.1.1 3.6 - 3.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we went no-arch in v0.2.1 (see #690), should the Python compatibility be >=3.6? Not sure how to test on Python 3.10 but it should technically work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do Python 3.6 codes always work with future Python versions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should? I think async/await became reserved names in 3.7 but PyGMT doesn't use those, or any advanced stuff really. Things should be safe until Python 4 at least.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, changed to ">=3.6".

@seisman seisman merged commit 2db46d0 into master Dec 29, 2020
@seisman seisman deleted the compatibility branch December 29, 2020 14:38
@weiji14 weiji14 added documentation Improvements or additions to documentation and removed maintenance Boring but important stuff for the core devs labels Feb 5, 2021
@seisman seisman mentioned this pull request Feb 14, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support table on forward/backward compatibility of PyGMT with Python and GMT versions

2 participants