Check files for UNIX-style line breaks and 644 permission#736
Merged
Check files for UNIX-style line breaks and 644 permission#736
Conversation
82335b7 to
ef9f647
Compare
Running `dos2unix` and check if there are any changes to make sure that we don't include any files with DOS-style line breaks.
ef9f647 to
a711a67
Compare
Member
Author
|
/format |
weiji14
reviewed
Dec 15, 2020
weiji14
reviewed
Dec 15, 2020
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
5 tasks
Member
|
I'll leave it up to you if you decide to implement the permissions (x, 755) check here or in a separate PR as discussed at #734 (comment). Also, we should probably have a policy statement in CONTRIBUTING.md on the use of UNIX style line-endings and correct permissions (644) of files. |
weiji14
reviewed
Dec 16, 2020
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Member
Author
I just added one sentence to address the policy. |
weiji14
reviewed
Dec 16, 2020
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Running
dos2unixto all Python scripts and check if there are any files changed,to make sure that we don't include any files with DOS-style line breaks.
The style checks fail due to #734. It also means that the line-break style check works as expected.
However, I can't use
/formatto automatically fix the line-break issue, as theslash command dispatch read the workflow in the master branch only.
Address #734.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Notes
/formatin the first line of a comment to lint the code automatically