Conversation
It seems @willschlitzer is developing PyGMT under Windows, and the new files he created have DOS-style line breaks. To keep the consistence in the whole project, I convert all these files to UNIX-style line breaks using `dos2unix`.
Contributor
|
Not sure on what's causing this; I'm using PyCharm Professional on Ubuntu 20.04 |
Member
|
Wow, good catch, would not have spotted that. Could you add the style check in this PR too if it's not too much work? @willschlitzer, try https://www.jetbrains.com/help/pycharm/configuring-line-endings-and-line-separators.html |
5 tasks
Member
|
So, chicken and egg question, do we merge this PR first, or #736 with the new style check? Also, should we have a style check for ensuring there's no executable 'x' permissions (755)? |
Member
Author
weiji14
approved these changes
Dec 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
It seems @willschlitzer is developing PyGMT under Windows, and the new
files he created have DOS-style line breaks.
To keep the consistency in the whole project, I convert all these files
to UNIX-style line breaks using
dos2unix. I don't know how gitand github handles line breaks, but I can't see the changes
in the diff view.
I also removed the
xpermission of these files.Perhaps we also need a style check for line breaks?
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Notes
/formatin the first line of a comment to lint the code automatically