Switch from versioneer to setuptools-scm#695
Merged
Conversation
Replace versioneer added in 3683f37 with the more modern [setuptools-scm](https://github.com/pypa/setuptools_scm).
a8ff2ff to
83a0c49
Compare
seisman
reviewed
Nov 17, 2020
weiji14
commented
Nov 17, 2020
setup.py
Outdated
| SETUP_REQUIRES = ["setuptools_scm"] | ||
| USE_SCM_VERSION = { | ||
| "local_scheme": "node-and-date", | ||
| "write_to": "_version.py", |
Member
Author
There was a problem hiding this comment.
I wonder if writing to a _version.py file is actually needed here.
Member
There was a problem hiding this comment.
https://github.com/fatiando/boule doesn't write the file.
Member
Author
There was a problem hiding this comment.
Ok, I'll remove this line then (and don't add _version.py to .gitignore too).
This reverts commit 8ac4cd3.
5 tasks
5 tasks
6 tasks
seisman
added a commit
to GenericMappingTools/sphinx_gmt
that referenced
this pull request
Apr 19, 2022
seisman
added a commit
to GenericMappingTools/sphinx_gmt
that referenced
this pull request
Apr 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Replace versioneer added in 3683f37 with the more modern setuptools-scm.
This PR mostly follows psf/black#1008, and fatiando/boule#61:
There is a_version.pyfile at the top-level which is git-ignored that contains a single line like__version__ = "0.2.2.dev3+g355d85f1"What this PR doesn't do:
Fixes #671
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Notes
/formatin the first line of a comment to lint the code automatically