Skip to content

Add a gallery example for varying transparent points#654

Merged
seisman merged 3 commits intomasterfrom
gallery/transparency
Oct 20, 2020
Merged

Add a gallery example for varying transparent points#654
seisman merged 3 commits intomasterfrom
gallery/transparency

Conversation

@seisman
Copy link
Member

@seisman seisman commented Oct 17, 2020 •
edited
Loading

Description of proposed changes

Add a gallery example for the new feature in #626.
image

Address #615.

Preview: https://pygmt-qmth2blje.vercel.app/gallery/plot/points-transparency.html

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@seisman seisman added the documentation Improvements or additions to documentation label Oct 17, 2020
@seisman seisman added this to the 0.2.1 milestone Oct 17, 2020
@seisman seisman requested a review from weiji14 October 17, 2020 06:34
@seisman
Copy link
Member Author

seisman commented Oct 19, 2020

Ping @weiji14 for a review.

@weiji14
Copy link
Member

weiji14 commented Oct 19, 2020

Sorry, a bit busy right now, so a quick comment instead of a full review. Could we use a simpler straight line example instead of a sine curve here? I.e. like this image in our unit test (but maybe modify it slightly)

circle transparency

@seisman
Copy link
Member Author

seisman commented Oct 19, 2020

The example is rewritten to plot the figure below.
image

weiji14
weiji14 reviewed Oct 20, 2020
View reviewed changes
@seisman @weiji14
Update examples/gallery/plot/points-transparency.py
02f37b7 
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@seisman seisman merged commit 060b723 into master Oct 20, 2020
@seisman seisman deleted the gallery/transparency branch October 20, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

0.2.1

Development

Successfully merging this pull request may close these issues.

2 participants

@seisman @weiji14