Skip to content

Let plot() accept record-by-record transparency#626

Merged
seisman merged 1 commit intomasterfrom
plot-transparency
Oct 15, 2020
Merged

Let plot() accept record-by-record transparency#626
seisman merged 1 commit intomasterfrom
plot-transparency

Conversation

@seisman
Copy link
Member

@seisman seisman commented Sep 21, 2020 •
edited
Loading

Description of proposed changes

plot() can accept a list of transparency so that each symbol can has its own transparency level.

Address #615.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@seisman seisman added the feature Brand new feature label Sep 21, 2020
@seisman seisman added this to the 0.2.1 milestone Sep 21, 2020
@seisman
Copy link
Member Author

seisman commented Sep 27, 2020 •
edited
Loading

The feature is already implemented, and I add three new tests for it.
However, I don't want to include the three baseline images (50 KB) to the git history.

@seisman seisman marked this pull request as ready for review October 15, 2020 15:33
@weiji14 weiji14 added enhancement Improving an existing feature and removed feature Brand new feature labels Oct 15, 2020
weiji14
weiji14 approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could use a gallery example but that can be done in a separate PR.

pygmt/tests/test_plot.py
fig_ref, fig_test = Figure(), Figure()
# Use single-character arguments for the reference image
with GMTTempFile() as tmpfile:
np.savetxt(tmpfile.name, np.c_[x, y], fmt="%d")
Copy link
Member

@weiji14 weiji14 Oct 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This np.c_ is new to me, but ok.

@seisman seisman merged commit 713ea72 into master Oct 15, 2020
@seisman seisman deleted the plot-transparency branch October 15, 2020 18:51
@seisman seisman mentioned this pull request Oct 17, 2020
Merged
5 tasks
@seisman seisman mentioned this pull request Oct 26, 2020
Merged
5 tasks
@weiji14 weiji14 mentioned this pull request Dec 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees

No one assigned

Labels

enhancement Improving an existing feature

Projects

None yet

Milestone

0.2.1

Development

Successfully merging this pull request may close these issues.

2 participants

@seisman @weiji14