Add a test for Session.write_data() writing netCDF grids#583
Merged
Conversation
`write_data()` can write a netCDF grid since GMT 6.1.1, if `geometry` is `GMT_IS_SURFACE`. This PR adds a test to make sure `write_data()` works as expected.
weiji14
reviewed
Sep 4, 2020
weiji14
approved these changes
Sep 4, 2020
Member
weiji14
left a comment
There was a problem hiding this comment.
Looks good, feel free to merge once the tests pass.
| def test_put_matrix_grid(): | ||
| "Check that assigning a numpy 2d array to a grid works" | ||
| "Check that assigning a numpy 2d array to an ASCII and NetCDF grid works" | ||
| dtypes = "float32 float64 int32 int64 uint32 uint64".split() |
Member
There was a problem hiding this comment.
Should probably use pytest parametrize for this, but we can leave it to a separate PR. Our test suite is getting larger and we might want to consider more efficient ways of testing (I'll open an issue for it).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
write_data()can write a netCDF grid since GMT 6.1.1, ifgeometryisGMT_IS_SURFACE.This PR adds a test to make sure
write_data()works as expected.Fixes #557.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.