Let surface return xr.DataArray instead of xr.Dataset#408
Merged
Conversation
Docstring for `surface` says that an xr.DataArray should be returned, but xr.Dataset is given instead. Doing a quick fix here to ensure that we output an xr.DataArray which is required by other PyGMT modules that take in a grid input.
Member
Author
|
Something seems to be up with our Continuous Integration/Deployment scripts (Codecov, Now and Travis?) but all of the status pages seem fine :/ Will leave it for now and retry tomorrow or so. |
Member
|
@weiji14 I've been having some trouble with Travis since they started that migration to their .com service. Not sure if that would break Now as well (seems unlikely). |
leouieda
approved these changes
Apr 9, 2020
Member
leouieda
left a comment
There was a problem hiding this comment.
👍 nice catch! Just need to figure out what's wrong with the CI but since tests pass, I'm fine with merging this.
Member
Author
Not sure if it's an intermittent issue, but will keep an eye 👀 out. |
weiji14
added a commit
to weiji14/deepbedmap
that referenced
this pull request
Jun 6, 2020
Bumps [pygmt](https://github.com/GenericMappingTools/pygmt) from 0.0.1a0-77-g4581a3e to 0.1.1! - [Release notes](https://github.com/GenericMappingTools/pygmt/releases) - [Changelog](https://github.com/GenericMappingTools/pygmt/blob/master/doc/changes.rst) - [Commits](GenericMappingTools/pygmt@0.0.1a0-77-g4581a3e...v0.1.1) Finally, with this proper pygmt version, we can get rid of a few of my thin wrappers (e.g. blockmedian, grdtrack, grdview) that have since made it into pygmt! Will do so in separate commits. Only made a small edit here to the xyz_to_grid function as pygmt.surface now returns an xarray.DataArray since GenericMappingTools/pygmt#408.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Docstring for
surfacesays that anxr.DataArrayshould be returned, butxr.Datasetis given instead. Doing a quick fix here to ensure that we output anxr.DataArraywhich is required by other PyGMT modules that take in a grid input.Fixes #407
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.