Skip to content

Change py.test to pytest#338

Merged
weiji14 merged 3 commits intoGenericMappingTools:masterfrom
Dovacody:master
Oct 10, 2019
Merged

Change py.test to pytest#338
weiji14 merged 3 commits intoGenericMappingTools:masterfrom
Dovacody:master

Conversation

@Dovacody
Copy link
Contributor

@Dovacody Dovacody commented Oct 9, 2019 •
edited
Loading

Description of proposed changes
After Careful review of the CONTRIBUTING.MD file, I found a typo on concerning pytest. Easy fix

Fixes #336

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@welcome
Copy link

welcome bot commented Oct 9, 2019

💖 Thanks for opening this pull request! 💖

Please make sure you read our contributing guidelines and abide by our code of conduct.

A few things to keep in mind:

  • If you need help writing tests, take a look at the existing ones for inspiration. If you don't know where to start, let us know and we'll walk you through it.
  • All new features should be documented. It helps to write the docstrings for your functions/classes before writing the code. This will help you think about your code design and results in better code.
  • No matter what, we are really grateful that you put in the effort to do this! 🎉

weiji14
weiji14 reviewed Oct 9, 2019
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @Dovacody! I didn't expect anyone to jump on so fast, it seems that there's a duplicate PR at #338 already. If you can find the other py.test by searching the project and fix that one too that'll be great!

@Dovacody
Copy link
Contributor Author

Dovacody commented Oct 9, 2019

Consider it done !

weiji14
weiji14 reviewed Oct 9, 2019
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magic! Now 2 more things left to do:

  1. You'll need to edit your initial post, and change the 'Fixes #' to 'Fixes #336' so that the issue will be automatically closed when we merge in that pull request.

  2. Update your branch by clicking on the "Update branch" button Oops, you beat me to it!

Oh, and you might want to change the title to Change py.test to pytest since it's not just the CONTRIBUTING.md file you're changing anymore.

@Dovacody Dovacody changed the title Fixed Typo in CONTRIBUTING.MD Change py.test to pytest Oct 10, 2019
@Dovacody
Copy link
Contributor Author

Dovacody commented Oct 10, 2019

Done and Done!

@weiji14 weiji14 merged commit ed73573 into GenericMappingTools:master Oct 10, 2019
@welcome
Copy link

welcome bot commented Oct 10, 2019

🎉🎉🎉 Congrats on merging your first pull request and welcome to the team! 🎉🎉🎉

Please open a new pull request to add yourself to the AUTHORS.md file. We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved.

@weiji14
Copy link
Member

weiji14 commented Oct 10, 2019

Awesome work @Dovacody! Just a small tip for your next Pull Request - make your changes on a 'patch' branch instead of working on the 'master' branch, as that could be problematic for fast moving projects that merge into 'master' often. Other than that, I hope you learnt something helpful today 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weiji14 weiji14 weiji14 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Easy typo fix] #dropthedot from py.test

2 participants

@Dovacody @weiji14