Conversation
GMT/Python is a bad name because it can't be translated into a repository or Python package name easily. What we have now is a repository called `gmt-python`, a website `gmtpython`, a package `gmt`, and a PyPI package `gmt-python`. This is madness. Since all other GMT Python wrappers are dead, we'll rebrand as PyGMT (repo and packages will be `pygmt`). This renames the package and imports so that the tests pass and the docs build. I'm sure we'll find many references to `gmt` but we can fix those with time. Fixes #263
weiji14
added a commit
to weiji14/deepbedmap
that referenced
this pull request
Feb 8, 2019
Couple of breaking changes. Since GenericMappingTools/pygmt#261, the conda-forge binary package is broken (hence all the recent CI build failures...) and we have to build the GMT binary from source, sigh. The new Dockerfile code for handling this isn't nice but it'll do for now. Also, the Python `gmt-python` package has been renamed to `pygmt` in GenericMappingTools/pygmt#265, so the Pipfile is updated accordingly here. Also pinning to a newer git version on the upstream branch instead of my personal fork, since GenericMappingTools/pygmt#245 has been merged in!
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GMT/Python is a bad name because it can't be translated into a
repository or Python package name easily. What we have now is a
repository called
gmt-python, a websitegmtpython, a packagegmt,and a PyPI package
gmt-python. This is madness.Since all other GMT Python wrappers are dead, we'll rebrand as PyGMT
(repo and packages will be
pygmt).This renames the package and imports so that the tests pass and the docs
build. I'm sure we'll find many references to
gmtbut we can fix thosewith time.
Fixes #263
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.