Update the test_subplot_outside_plotting_positioning test and increase the RMS tolerance#2454
Merged
Update the test_subplot_outside_plotting_positioning test and increase the RMS tolerance#2454
Conversation
…works with GMT 6.3
Member
Author
|
/test-gmt-dev Workflow run at https://github.com/GenericMappingTools/pygmt/actions/runs/4497014198. |
Member
Author
|
Now the test passes in the Tests (https://github.com/GenericMappingTools/pygmt/actions/runs/4497107567?pr=2454), the "GMT Dev Tests" (https://github.com/GenericMappingTools/pygmt/actions/runs/4497014198) and also the "GMT Legacy Tests" (https://github.com/GenericMappingTools/pygmt/actions/runs/4497107573). The two failures in the "GMT Legacy Tests" are related to the doctests, which will be addressed in #2286, #2443 and #2450. |
weiji14
reviewed
Mar 23, 2023
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
seisman
commented
Mar 23, 2023
weiji14
approved these changes
Mar 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The test
test_subplot_outside_plotting_positioningfails in the latest run of the "GMT Legacy Tests" (see https://github.com/GenericMappingTools/pygmt/actions/runs/4474241635/jobs/7862497307).It fails due to an upstream bug that affects GMT 6.3.0 only (see GenericMappingTools/gmt#6100).
In this PR, I remove
frame=Truefrom the test so that it works with both GMT 6.3 and 6.4.I also increase the RMS tolerance to 4.0 so that the test passes for GMT master branch.
Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version