Add a new target 'doctest' to run doctests only and simplify Makefile#2443
Merged
Add a new target 'doctest' to run doctests only and simplify Makefile#2443
Conversation
willschlitzer
approved these changes
Mar 22, 2023
Contributor
willschlitzer
left a comment
There was a problem hiding this comment.
I think this is a good change. I haven't worked with Makefiles, but the new syntax looks correct. Everything works on my computer.
Merged
7 tasks
michaelgrund
approved these changes
Mar 23, 2023
Member
Author
|
Ping @weiji14 do you have more comments on the changes? |
weiji14
approved these changes
Mar 23, 2023
Member
weiji14
left a comment
There was a problem hiding this comment.
Was just checking this out. Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This is the first step to address #2286 (comment).
Changes in this PR:
_runtesttarget to run the tests. Other targetstests,fulltests,doctest,test_no_imagesall depend on the_runtesttarget. For each target, different values forPYTEST_ARGSare passed, so that different tests are execuated.doctesttarget which only runs the doctests, as suggested in Run full tests (including inline doctests) in workflows #2286 (comment)testtargetTo test this PR, you can run
make <target>to see which tests run.To save your time, you can simply add
--collect-only(only collect the tests and don't run them) to pytest, i.e., changing line 37 toHere are the counts of tests when I run these targets:
make test: 659make fulltest: 696make doctest: 68make test_no_images: 696Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version