Skip to content

load_earth_relief: Add import statement to inline examples#2229

Merged
seisman merged 4 commits intomainfrom
earth-relief-example-update
Dec 7, 2022
Merged

load_earth_relief: Add import statement to inline examples#2229
seisman merged 4 commits intomainfrom
earth-relief-example-update

Conversation

@willschlitzer
Copy link
Contributor

Add from pygmt.datasets import load_earth_relief to the top of the inline example in earth_relief.py.

This also adds resolution= before the resolution arguments in the example.

Addresses #2225

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added enhancement Improving an existing feature skip-changelog Skip adding Pull Request to changelog labels Dec 6, 2022
@willschlitzer willschlitzer added this to the 0.8.0 milestone Dec 6, 2022
@willschlitzer willschlitzer self-assigned this Dec 6, 2022
@willschlitzer willschlitzer added documentation Improvements or additions to documentation and removed enhancement Improving an existing feature labels Dec 6, 2022
@willschlitzer willschlitzer marked this pull request as ready for review December 6, 2022 13:59
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Dec 6, 2022
willschlitzer and others added 2 commits December 6, 2022 19:02
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@seisman seisman changed the title Add import statement to earth_relief.py inline example load_earth_relief: Add import statement to inline examples Dec 7, 2022
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Dec 7, 2022
@seisman seisman merged commit 01344f8 into main Dec 7, 2022
@seisman seisman deleted the earth-relief-example-update branch December 7, 2022 08:13
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…ppingTools#2229)

Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants