Conversation
Member
Author
|
/format |
seisman
reviewed
Nov 23, 2022
pygmt/src/velo.py
Outdated
| B="frame", | ||
| C="cmap", | ||
| D="rescale", | ||
| E="uncertaintycolor", |
Member
There was a problem hiding this comment.
I'm wondering if we should also deprecated uncertaintycolor to uncertaintyfill.
Member
Author
There was a problem hiding this comment.
In my opinion, yes since it also colors the inside of a polygon! I made some changes. If we go with uncertaintyfill then test_velo.py also needs to be updated.
Member
There was a problem hiding this comment.
Yes, please also update test_velo.py then we can ping other maintainers to see what they think about the two deprecations.
6 tasks
seisman
approved these changes
Nov 24, 2022
Member
seisman
left a comment
There was a problem hiding this comment.
Looks good to me, but let's see what other @GenericMappingTools/pygmt-maintainers say about the two deprecated parameters.
weiji14
approved these changes
Nov 24, 2022
Member
weiji14
left a comment
There was a problem hiding this comment.
Yep, ok with double deprecation!
Merged
6 tasks
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…olor" to "uncertaintyfill" (remove in v0.12.0) (GenericMappingTools#2206)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1617
Description of proposed changes
Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version