Skip to content

Figure.plot: Deprecate parameter "color" to "fill" (remove in v0.12.0)#2177

Merged
seisman merged 1 commit intomainfrom
plot-deprecate-color-to-fill
Nov 7, 2022
Merged

Figure.plot: Deprecate parameter "color" to "fill" (remove in v0.12.0)#2177
seisman merged 1 commit intomainfrom
plot-deprecate-color-to-fill

Conversation

@seisman
Copy link
Member

@seisman seisman commented Oct 30, 2022

Description of proposed changes

Related to #1617.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman force-pushed the plot-deprecate-color-to-fill branch from 5c40311 to 8e75f09 Compare October 30, 2022 08:00
@seisman seisman added the deprecation Deprecating a feature label Oct 30, 2022
@seisman seisman added this to the 0.8.0 milestone Oct 30, 2022
@seisman seisman mentioned this pull request Oct 30, 2022
Closed
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Oct 31, 2022
@seisman
Copy link
Member Author

seisman commented Nov 4, 2022

Ping @GenericMappingTools/pygmt-maintainers for a final review because plot is widely used so the deprecation will affect many users.

michaelgrund
michaelgrund approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@michaelgrund michaelgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@weiji14
Copy link
Member

weiji14 commented Nov 4, 2022

Can we rename the PR title to "Figure.plot: Deprecate parameter "color" to "fill" (remove in v0.12.0)", since this is just a deprecation warning and not a full removal yet?

@seisman seisman changed the title Figure.plot: Remove parameter "color", use "fill" instead Figure.plot: Deprecate parameter "color" to "fill" (remove in v0.12.0) Nov 5, 2022
@seisman seisman merged commit 93b2426 into main Nov 7, 2022
@seisman seisman deleted the plot-deprecate-color-to-fill branch November 7, 2022 11:21
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Nov 7, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@seisman
Figure.plot: Deprecate parameter "color" to "fill" (remove in v0.12.0) (
0056001 
GenericMappingTools#2177)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelgrund michaelgrund michaelgrund approved these changes

Assignees

No one assigned

Labels

deprecation Deprecating a feature

Projects

None yet

Milestone

0.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@seisman @weiji14 @michaelgrund