Skip to content

blockm/contour/plot/plot3d/rose/surface/wiggle: Change the parameter order of data array and input arrays#1978

Merged
seisman merged 5 commits intomainfrom
deprecate-data-order
Jun 30, 2022
Merged

blockm/contour/plot/plot3d/rose/surface/wiggle: Change the parameter order of data array and input arrays#1978
seisman merged 5 commits intomainfrom
deprecate-data-order

Conversation

@seisman
Copy link
Member

@seisman seisman commented Jun 24, 2022

Description of proposed changes

Related to #1966

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the deprecation Deprecating a feature label Jun 24, 2022
@seisman seisman added this to the 0.7.0 milestone Jun 24, 2022
@seisman seisman mentioned this pull request Jun 26, 2022
26 tasks
@seisman
Copy link
Member Author

seisman commented Jun 28, 2022

Ping @GenericMappingTools/pygmt-maintainers to review this final PR before releasing v0.7.0

Copy link
Member

@michaelgrund michaelgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed final review call This PR requires final review and approval from a second reviewer labels Jun 29, 2022
@seisman seisman merged commit cfbc3bb into main Jun 30, 2022
@seisman seisman deleted the deprecate-data-order branch June 30, 2022 01:01
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Deprecating a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants