Skip to content

Figure.wiggle: Remove parameter 'columns', use 'incols' instead.#1977

Merged
seisman merged 4 commits intomainfrom
wiggle-deprecate
Jun 24, 2022
Merged

Figure.wiggle: Remove parameter 'columns', use 'incols' instead.#1977
seisman merged 4 commits intomainfrom
wiggle-deprecate

Conversation

@seisman
Copy link
Member

@seisman seisman commented Jun 23, 2022

Description of proposed changes

Related to #1966.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the deprecation Deprecating a feature label Jun 23, 2022
@seisman seisman added this to the 0.7.0 milestone Jun 23, 2022
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Jun 24, 2022
@seisman seisman merged commit 37ab418 into main Jun 24, 2022
@seisman seisman deleted the wiggle-deprecate branch June 24, 2022 04:23
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jun 24, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…ericMappingTools#1977)

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Deprecating a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants