Merged
Conversation
seisman
approved these changes
Jun 15, 2022
6 tasks
weiji14
reviewed
Jun 15, 2022
Comment on lines
+185
to
+186
| assert summary.loc["min", "date"] == 1958.2027 | ||
| assert summary.loc["max", "date"] == 2019.3699 |
Member
There was a problem hiding this comment.
Is the date column a floating point column? Should we convert it to a proper pandas datetime dtype?
Contributor
Author
There was a problem hiding this comment.
It is a floating point number in the original dataset. My concern with converting to a date time object is that the GMT API won't recognize that input.
Member
There was a problem hiding this comment.
PyGMT does work with datetime I'm sure. See https://www.pygmt.org/v0.6.1/tutorials/advanced/date_time_charts.html?highlight=datetime
Contributor
Author
There was a problem hiding this comment.
@GenericMappingTools/pygmt-maintainers Does anyone else have an input on this? My thought is to maintain the original date type in the remote file as a float, but I don't feel that strongly.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
michaelgrund
approved these changes
Jun 17, 2022
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
@MaunaLoa_CO2.txttoload_sample_data().Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version