Conversation
willschlitzer
approved these changes
May 24, 2022
Contributor
willschlitzer
left a comment
There was a problem hiding this comment.
Good improvement to this tutorial
michaelgrund
approved these changes
May 24, 2022
Member
Author
|
I mark the PR as a draft due to the concern/issue mentioned in #1930 (comment) |
Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
Member
Author
|
As explained in GenericMappingTools/gmt#6751 (comment), a better solution is specifying -R and -J in inset begin so that inset can determine the inset width and height automatically. I think this is an intuitive solution and should be recommended, so I have updated the two examples accoordingly. Unfortunately, -R and -J are not aliased in PyGMT v0.6.1, so this PR also adds the aliases for -R and -J. Some TODOs:
Please let me know what you think before I start to work on them. |
michaelgrund
approved these changes
Jun 24, 2022
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…ols#1931) Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Fix two inset examples as pointed out in #1930 (comment).
Closes #1930.