Skip to content

Update GMT-6.4 baseline image for test_config tests#1901

Merged
seisman merged 1 commit intogmt-6.4from
fix-test_confi
Apr 30, 2022
Merged

Update GMT-6.4 baseline image for test_config tests#1901
seisman merged 1 commit intogmt-6.4from
fix-test_confi

Conversation

@seisman
Copy link
Member

@seisman seisman commented Apr 26, 2022

Description of proposed changes

The two test_config tests fail due to the upstream changes in rose placements (see GenericMappingTools/gmt#6213, GenericMappingTools/gmt#6215, and GenericMappingTools/gmt#6626).

Name OLD NEW
test_config_font_annot baseline result
test_config_font_one baseline result

As you can see, with GMT 6.4, the two map roses overlap, so I modify the two tests to make sure they are well separated.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman mentioned this pull request Apr 26, 2022
69 tasks
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Apr 26, 2022
@seisman seisman added this to the 0.7.0 milestone Apr 26, 2022
@seisman seisman merged commit 6615e25 into gmt-6.4 Apr 30, 2022
@seisman seisman deleted the fix-test_confi branch April 30, 2022 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant