Must check for label content before offsetting#6626
Merged
PaulWessel merged 5 commits intomasterfrom Apr 26, 2022
Merged
Conversation
In the magnetic map rose case, we examine if there are labels to plot (hence we need to do more offsets) but that test was flawed. It checked if the pointer existed (it always does) insteaf of its content (may be empty).
Member
Author
|
The same disease afflicted the directional rose offset calculation. I have also adjusted the amount of offset to be more suitable. This makes the mag_roses.sh file but I can fix that once you agree this is a better design. |
seisman
approved these changes
Apr 26, 2022
6 tasks
PaulWessel
added a commit
that referenced
this pull request
Apr 26, 2022
After doing the fixes in #6626.
PaulWessel
added a commit
that referenced
this pull request
Apr 26, 2022
After doing the fixes in #6626.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the magnetic map rose case, we examine if there are labels to plot (hence we need to do more offsets) but that test was flawed. It checked if the pointer existed (it always does) instead of its content (may be empty).
This PR fixes that bug. It is related to the issues in #6213 but probably not the last word. That may be a mix of this bug (now fixed) and design decisions since the default offset still looks a wee bit too large?