Added alias for F in basemap#1894
Conversation
|
💖 Thanks for opening this pull request! 💖 Please make sure you read our contributing guidelines and abide by our code of conduct. A few things to keep in mind:
|
|
Thanks for opening this PR @jackbeagley. Besides adding an alias for |
@jackbeagley FYI, the same Line 71 in 555cd31 |
|
@seisman , awesome, I have just copied the description from |
|
Does a test need to be written for this too? |
I don't think a test is needed for such an alias. |
michaelgrund
left a comment
There was a problem hiding this comment.
I think we have to consider the different types of map objects that can be manipulated such as map inset, map scale, or map rose.
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Hey @michaelgrund, is that what you had in mind? |
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
|
🎉🎉🎉 Congrats on merging your first pull request and welcome to the team! 🎉🎉🎉 Please open a new pull request to add yourself to the |
Co-authored-by: Dongdong Tian <seisman.info@gmail.com> Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Description of proposed changes
Adds an alias for "box" so that backgrounds and frames for map_scales can be generated more easily.
Fixes #1893
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version