Skip to content

Figure.plot/plot3d: Remove parameter "sizes", use "size" instead#1809

Merged
weiji14 merged 1 commit intomainfrom
remove/sizes_to_size
Mar 13, 2022
Merged

Figure.plot/plot3d: Remove parameter "sizes", use "size" instead#1809
weiji14 merged 1 commit intomainfrom
remove/sizes_to_size

Conversation

@weiji14
Copy link
Member

@weiji14 weiji14 commented Mar 13, 2022

Description of proposed changes

Remove the parameter "sizes" in favour of "size" from Figure.plot and Figure.plot3d. Deprecation warning was added in v0.4.0 (xref #1254, #1258), and is to be fully removed in v0.6.0.

Part of #1801.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@weiji14 weiji14 added the deprecation Deprecating a feature label Mar 13, 2022
@weiji14 weiji14 added this to the 0.6.0 milestone Mar 13, 2022
@weiji14 weiji14 self-assigned this Mar 13, 2022
@weiji14 weiji14 mentioned this pull request Mar 13, 2022
28 tasks
@weiji14 weiji14 marked this pull request as ready for review March 13, 2022 13:08
@weiji14 weiji14 merged commit 9b1d516 into main Mar 13, 2022
@weiji14 weiji14 deleted the remove/sizes_to_size branch March 13, 2022 13:27
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…ericMappingTools#1809)

Remove the parameter "sizes" in favour of "size" from `Figure.plot`
and `Figure.plot3d`. Deprecation warning was added in v0.4.0
(xref GenericMappingTools#1254, GenericMappingTools#1258), and is to be fully removed in v0.6.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Deprecating a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants