Skip to content

Update fig.basemap baseline images for GMT 6.3.0#1658

Merged
weiji14 merged 2 commits intomainfrom
gmt-6.3.0/basemap
Dec 14, 2021
Merged

Update fig.basemap baseline images for GMT 6.3.0#1658
weiji14 merged 2 commits intomainfrom
gmt-6.3.0/basemap

Conversation

@weiji14
Copy link
Member

@weiji14 weiji14 commented Dec 14, 2021

Description of proposed changes

Fix two broken tests on GMT 6.3.0 for fig.basemap. Changes mainly due to small differences in axis labels.

Part of #1644

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

Fix two broken tests on GMT 6.3.0 for fig.basemap. Changes mainly due to small differences in axis labels.
@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Dec 14, 2021
@weiji14 weiji14 added this to the 0.6.0 milestone Dec 14, 2021
@weiji14 weiji14 self-assigned this Dec 14, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2021

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
modified pygmt/tests/baseline/test_basemap_compass.png
modified pygmt/tests/baseline/test_basemap_rose.png

Image diff(s)

Details

Added images

Modified images

Path Old New
test_basemap_compass.png
test_basemap_rose.png

Report last updated at commit ee1c462

@weiji14 weiji14 marked this pull request as ready for review December 14, 2021 02:01
@weiji14 weiji14 merged commit 9ef6338 into main Dec 14, 2021
@weiji14 weiji14 deleted the gmt-6.3.0/basemap branch December 14, 2021 03:14
@weiji14 weiji14 mentioned this pull request Dec 14, 2021
31 tasks
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…#1658)

Fix two broken tests on GMT 6.3.0 for fig.basemap.
Changes mainly due to small differences in axis labels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants