Conversation
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
left a comment
There was a problem hiding this comment.
Looks good to me after fixing a typo.
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
|
@GenericMappingTools/pygmt-maintainers Hopefully someone else can give this PR a final review. |
maxrjones
left a comment
There was a problem hiding this comment.
Great work, @willschlitzer!
The only important comment here is to include @capitals.gmt in the download_test_data function since that's used for caching the files for the CI.
I agree with #1652 (comment) that the output to file option can be added later since it's more similar to #896 than #1536.
There's some work that needs to be done for managing required arguments, but I think we need some more consistency regarding that throughout the library and it's not a reason to hold this feature back.
| Test binstats with no set outgrid. | ||
| """ | ||
| temp_grid = binstats( | ||
| data="@capitals.gmt", |
There was a problem hiding this comment.
Can you add this to pygmt.helpers.testing.download_test_data?
Co-authored-by: Max Jones <meghanj@alum.mit.edu>
*Wrap gmtbinstats function *Add test_binstats.py *Add binstats to API index *Add remote files "@capitals.gmt" to cached files Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com> Co-authored-by: Dongdong Tian <seisman.info@gmail.com> Co-authored-by: Max Jones <meghanj@alum.mit.edu>
This wraps the GMT module
gmtbinstats.