Skip to content

Add gallery example to showcase blockmean#1598

Merged
maxrjones merged 16 commits intomainfrom
gallery-blockmean-eq
Nov 21, 2021
Merged

Add gallery example to showcase blockmean#1598
maxrjones merged 16 commits intomainfrom
gallery-blockmean-eq

Conversation

@michaelgrund
Copy link
Member

@michaelgrund michaelgrund commented Oct 31, 2021 •
edited by weiji14
Loading

Description of proposed changes

Partly addressing #1352 here's a gallery example in which two different usages of blockmean are shown using the build-in japan_quake dataset.

Preview at https://pygmt-git-gallery-blockmean-eq-gmt.vercel.app/gallery/histograms/blockm.html

blockmean gallery example

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@michaelgrund michaelgrund added the documentation Improvements or additions to documentation label Oct 31, 2021
@michaelgrund michaelgrund added this to the 0.6.0 milestone Oct 31, 2021
@michaelgrund michaelgrund marked this pull request as draft October 31, 2021 14:06
@michaelgrund
Copy link
Member Author

michaelgrund commented Oct 31, 2021

Btw, are there any specific reasons why no alias for the -S flag is available so far @GenericMappingTools/pygmt-maintainers ?

@michaelgrund michaelgrund marked this pull request as ready for review October 31, 2021 14:18
@michaelgrund michaelgrund marked this pull request as draft October 31, 2021 14:25
@weiji14
Copy link
Member

weiji14 commented Oct 31, 2021

Btw, are there any specific reasons why no alias for the -S flag is available so far @GenericMappingTools/pygmt-maintainers ?

Not yet implemented I guess. Maybe open a separate PR to add it.

P.S. You should add a .py to the end of the filename.

P.P.S. The macOS docs build is failing due to an unrelated reason. Will open a separate issue or maintenance PR to resolve it.

@michaelgrund michaelgrund mentioned this pull request Nov 1, 2021
Merged
5 tasks
@willschlitzer willschlitzer marked this pull request as ready for review November 5, 2021 06:04
@willschlitzer willschlitzer marked this pull request as draft November 5, 2021 06:04
@willschlitzer
Copy link
Contributor

willschlitzer commented Nov 5, 2021

Sorry for accidentally marking this "Ready for review." Already converted back to draft.

willschlitzer
willschlitzer reviewed Nov 5, 2021
View reviewed changes
@michaelgrund @willschlitzer
Update examples/gallery/histograms/blockm.py
62f941b 
Co-authored-by: Will Schlitzer <schlitzer90@gmail.com>
@michaelgrund michaelgrund marked this pull request as ready for review November 9, 2021 18:08
@michaelgrund michaelgrund self-assigned this Nov 10, 2021
willschlitzer
willschlitzer reviewed Nov 18, 2021
View reviewed changes
@michaelgrund @willschlitzer
Apply suggestions from code review
a500bd1 
Co-authored-by: Will Schlitzer <schlitzer90@gmail.com>
willschlitzer
willschlitzer reviewed Nov 18, 2021
View reviewed changes
Copy link
Contributor

@willschlitzer willschlitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few additional comments! Sorry that I didn't catch it on the first pass @michaelgrund

@michaelgrund @willschlitzer
Apply suggestions from code review
53e5c62 
Co-authored-by: Will Schlitzer <schlitzer90@gmail.com>
@willschlitzer
Copy link
Contributor

willschlitzer commented Nov 18, 2021

/format

willschlitzer
willschlitzer approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@willschlitzer willschlitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just the one suggestion

willschlitzer
willschlitzer reviewed Nov 19, 2021
View reviewed changes
@michaelgrund @willschlitzer
Apply suggestions from code review
fca3f12 
Co-authored-by: Will Schlitzer <schlitzer90@gmail.com>
@willschlitzer willschlitzer added the final review call This PR requires final review and approval from a second reviewer label Nov 19, 2021
seisman
seisman approved these changes Nov 20, 2021
View reviewed changes
@michaelgrund @seisman
Apply suggestions from code review
ce03917 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@maxrjones maxrjones merged commit eaa214d into main Nov 21, 2021
@maxrjones maxrjones deleted the gallery-blockmean-eq branch November 21, 2021 23:50
@maxrjones maxrjones removed the final review call This PR requires final review and approval from a second reviewer label Nov 21, 2021
@weiji14 weiji14 mentioned this pull request Dec 14, 2021
Open
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@michaelgrund @willschlitzer @seisman
Add gallery example to showcase blockmean (GenericMappingTools#1598)
d9db5c5 
Co-authored-by: Will Schlitzer <schlitzer90@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willschlitzer willschlitzer willschlitzer approved these changes

@seisman seisman seisman approved these changes

@maxrjones maxrjones maxrjones approved these changes

Assignees

@michaelgrund michaelgrund

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

0.6.0

Development

Successfully merging this pull request may close these issues.

5 participants

@michaelgrund @weiji14 @willschlitzer @seisman @maxrjones