Skip to content

Figure.rose: Reorder input parameters to 'data, length, azimuth'#1546

Merged
weiji14 merged 9 commits intomainfrom
rose-reorder-paras
Oct 3, 2021
Merged

Figure.rose: Reorder input parameters to 'data, length, azimuth'#1546
weiji14 merged 9 commits intomainfrom
rose-reorder-paras

Conversation

@michaelgrund
Copy link
Member

Description of proposed changes

Address #1479

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@michaelgrund michaelgrund added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Sep 26, 2021
@michaelgrund michaelgrund added this to the 0.5.0 milestone Sep 26, 2021
@michaelgrund michaelgrund changed the title Figure.rose(): Reorder parameters length, azimuth, data to data, length, azimuth Figure.rose: Reorder parameters length, azimuth, data to data, length, azimuth Sep 26, 2021
@michaelgrund michaelgrund changed the title Figure.rose: Reorder parameters length, azimuth, data to data, length, azimuth Figure.rose: Reorder parameters to 'data, length, azimuth' Sep 27, 2021
@michaelgrund michaelgrund changed the title Figure.rose: Reorder parameters to 'data, length, azimuth' Figure.rose: Reorder input parameters to 'data, length, azimuth' Sep 27, 2021
@seisman seisman added deprecation Deprecating a feature maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog and removed skip-changelog Skip adding Pull Request to changelog maintenance Boring but important stuff for the core devs labels Oct 2, 2021
@seisman seisman removed maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Oct 2, 2021
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Oct 2, 2021
@weiji14 weiji14 merged commit b5f825e into main Oct 3, 2021
@weiji14 weiji14 deleted the rose-reorder-paras branch October 3, 2021 02:01
@weiji14 weiji14 removed the final review call This PR requires final review and approval from a second reviewer label Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Deprecating a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants