Skip to content

Figure.histogram: Deprecate parameter "table" to "data" (remove in v0.7.0)#1540

Merged
seisman merged 3 commits intomainfrom
histogram-deprecate-table-to-data
Sep 27, 2021
Merged

Figure.histogram: Deprecate parameter "table" to "data" (remove in v0.7.0)#1540
seisman merged 3 commits intomainfrom
histogram-deprecate-table-to-data

Conversation

@seisman
Copy link
Member

@seisman seisman commented Sep 24, 2021

Description of proposed changes

I don't add a test for this deprecation, because we already have a similar test for pygmt.info in PR #1538.

Address #1479

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@weiji14 weiji14 added the deprecation Deprecating a feature label Sep 25, 2021
@seisman seisman added this to the 0.5.0 milestone Sep 25, 2021
Copy link
Contributor

@willschlitzer willschlitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@willschlitzer willschlitzer added final review call This PR requires final review and approval from a second reviewer skip-changelog Skip adding Pull Request to changelog labels Sep 26, 2021
@seisman seisman removed the skip-changelog Skip adding Pull Request to changelog label Sep 26, 2021
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Sep 27, 2021
@seisman seisman merged commit 3861935 into main Sep 27, 2021
@seisman seisman deleted the histogram-deprecate-table-to-data branch September 27, 2021 02:59
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
….7.0) (GenericMappingTools#1540)

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Deprecating a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants