Add a gallery example showing the usage of text symbols#1522
Merged
Conversation
This PR adds adds a gallery example that shows the usage of text symbols via ``Figure.plot()``
Member
|
Is "text symbols" different from normal texts? Why not using the |
Member
Author
I expanded the docstring and added a further sentence that is used in the GMT docs explaining why to use text symbols. In my opinion we should at least mention that it's possible to plot text symbols also via |
seisman
approved these changes
Sep 20, 2021
Member
seisman
left a comment
There was a problem hiding this comment.
The example looks good to me except a few suggestions.
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
weiji14
approved these changes
Sep 20, 2021
Member
weiji14
left a comment
There was a problem hiding this comment.
Had an idea to spell out 'πgmt', but ok with this example too 😆
Member
Author
Nice idea but I think it's not possible to mix Symbols and standard text here. |
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…ngTools#1522) Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR adds a gallery example that shows the usage of text symbols via
Figure.plot().Preview at https://pygmt-git-gallery-text-symbols-gmt.vercel.app/gallery/symbols/text_symbols.html
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version