Skip to content

Wrap dimfilter#1492

Merged
seisman merged 30 commits intomainfrom
wrap-dimfilter
Apr 11, 2022
Merged

Wrap dimfilter#1492
seisman merged 30 commits intomainfrom
wrap-dimfilter

Conversation

@willschlitzer
Copy link
Contributor

@willschlitzer willschlitzer commented Sep 11, 2021

This pull request wraps the function dimfilter.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added the feature Brand new feature label Sep 11, 2021
@willschlitzer willschlitzer added this to the 0.5.0 milestone Sep 11, 2021
@willschlitzer willschlitzer self-assigned this Sep 11, 2021
@willschlitzer willschlitzer changed the title WIP: Wrap dimfilter Wrap dimfilter Sep 12, 2021
@willschlitzer willschlitzer marked this pull request as ready for review September 12, 2021 10:55
@willschlitzer willschlitzer modified the milestones: 0.5.0, 0.6.0 Oct 7, 2021
@willschlitzer willschlitzer requested a review from a team November 19, 2021 07:20
@maxrjones
Copy link
Member

maxrjones commented Dec 4, 2021

Sorry for keeping you waiting on a review for this module! dimfilter will be a great addition to the PyGMT processing modules 🎉 I am hoping to find time to check out the branch within the next week.

maxrjones
maxrjones reviewed Dec 22, 2021
View reviewed changes
@willschlitzer
Apply suggestions from code review
f0e88f4 
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
@weiji14 weiji14 modified the milestones: 0.6.0, 0.7.0 Mar 13, 2022
@willschlitzer @weiji14
Update pygmt/src/dimfilter.py
bb33afd 
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
seisman
seisman reviewed Mar 17, 2022
View reviewed changes
@willschlitzer @seisman
Update pygmt/src/dimfilter.py
0efbd83 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
weiji14
weiji14 reviewed Mar 18, 2022
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor docstring comments. The implementation looks quite good already, and we could merge this new feature 'soon' after a final review, but it'll depend on whether we want to do a PyGMT v0.6.1 or jump straight to PyGMT v0.7.0.

I say we wait until the end of March 2022, and if there isn't any major bug that pops up with users using PyGMT v0.6.0, then we'll jump straight to v0.7.0. What do you think?

@willschlitzer @weiji14
Apply suggestions from code review
388b521 
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@willschlitzer
Copy link
Contributor Author

willschlitzer commented Mar 19, 2022

I say we wait until the end of March 2022, and if there isn't any major bug that pops up with users using PyGMT v0.6.0, then we'll jump straight to v0.7.0. What do you think?

That's fine with me; I'm just hoping to get this wrapped up relatively soon since it's been an open for 6 months.

@seisman
Copy link
Member

seisman commented Mar 21, 2022

I say we wait until the end of March 2022, and if there isn't any major bug that pops up with users using PyGMT v0.6.0, then we'll jump straight to v0.7.0. What do you think?

I agree.

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Mar 21, 2022
@willschlitzer
Copy link
Contributor Author

willschlitzer commented Apr 1, 2022

@GenericMappingTools/pygmt-maintainers Are we still holding off for v0.6.1 or am I good to merge this?

@seisman
Copy link
Member

seisman commented Apr 1, 2022

We will release v0.6.1 soon #1856.

@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Apr 11, 2022
@seisman seisman merged commit 2304053 into main Apr 11, 2022
@seisman seisman deleted the wrap-dimfilter branch April 11, 2022 14:58
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@willschlitzer @seisman @weiji14
Wrap dimfilter (GenericMappingTools#1492)
705e573 
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@weiji14 weiji14 mentioned this pull request Mar 30, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxrjones maxrjones maxrjones left review comments

@weiji14 weiji14 weiji14 left review comments

@seisman seisman seisman approved these changes

Assignees

@willschlitzer willschlitzer

Labels

feature Brand new feature

Projects

None yet

Milestone

0.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@willschlitzer @maxrjones @seisman @weiji14