Let Flake8 check examples and fix warnings#1477
Merged
Conversation
added 8 commits
August 31, 2021 13:19
weiji14
approved these changes
Sep 1, 2021
Member
weiji14
left a comment
There was a problem hiding this comment.
My eyes glossed over after scanning through diffs on 30-ish files... But ok with merging this big diff since you've done the hard work already. Thanks!
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Member
Author
|
Any ideas what's wrong with the windows tests? |
Member
The Windows tests fail randomly sometimes. Maybe restart the tests (usually I would just ignore it, but since this is a big PR, best be safe). |
Member
|
FYI, I just restarted the tests. |
Member
|
Thanks @seisman, all tests pass now! I'll merge this in. |
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
This PR enables flake8 checking of the examples directory and fixes resulting warnings. * Update line lengths in gallery * Update line lengths for tutorials * Update whitespace and line length in projection gallery * Update rose line length * Fix invalid escape sequences * Fix grdsample sphinx warning * Update examples/gallery/symbols/datetime_inputs.py * Format grdlandmask example Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR enables flake8 checking of the examples directory and fixes resultant warnings.
The diff is very large because of the line length configuration (opinions welcome for whether this is worth the benefit of having style checks for the examples).
Fixes #948
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version