Conversation
|
I'm getting a weird problem where the axis labels on the right-side (b) axis isn't showing up. I'm not sure what I'm missing, as this follows along with the example on the GMT page for |
This was a bug in GMT in 6.2.0, which was fixed by GenericMappingTools/gmt#5431. |
@meghanrjones Is there a workaround for GMT 6.2.0, or will this plotting bug be the case until GMT releases a new version and PyGMT uses it? |
You could try using pygmt.config(MAP_FRAME_AXIS, "WSE"), though using that internally would prevent users from overriding it unless you found a way to check whether the setting has been configured in the session. Edit: To be more clear, it would need to be in a context manager for pygmt.ternary calls so that it doesn't impact other function calls. |
I think calling |
|
Since we've bumped PyGMT's minimum GMT version to 6.3.0, do you want to give this PR another go @willschlitzer? |
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)Report last updated at commit 33b200e |
weiji14
left a comment
There was a problem hiding this comment.
First round of review. Implementation look ok, but the docs could use a bit of work. Could you please add ternary to doc/api/index.rst so that we can see the preview docs? Thanks!
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
|
/format |
|
Hi @willschlitzer, I think this PR is good to merge after two small in-line suggestions (one for a line length issue to satisfy pylint and one to add a reference to plotting styles). Would you be open to moving forward with a merge rather than closing the PR? |
|
@meghanrjones Not sure how I managed this (currently on a work computer), but didn't mean to close it! Thanks |
| counter-clockwise direction]. | ||
| {R} | ||
| {CPT} | ||
| {G} |
There was a problem hiding this comment.
I think we can ignore it now and address the issue in #1617 instead.
|
@willschlitzer I think this PR is almost ready for merge. I'm wondering if you have some time to finalize this PR recently. |
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
|
/format |
|
The tests fail, likely due to the outdated baseline image. Could you please regenerate the baseline image using GMT 6.4.0 again? |
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com> Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

This pull request wraps the GMT function
ternary.Preview docs at https://pygmt-git-wrap-ternary-gmt.vercel.app/api/generated/pygmt.Figure.ternary.html
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version