Add common option aliases to COMMON_OPTIONS in decorators.py#1407
Merged
Add common option aliases to COMMON_OPTIONS in decorators.py#1407
Conversation
weiji14
reviewed
Aug 3, 2021
Member
weiji14
left a comment
There was a problem hiding this comment.
Just a few fullstops to add and one entry which needs extra indentation.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14
approved these changes
Aug 4, 2021
Member
weiji14
left a comment
There was a problem hiding this comment.
Looks alright to me. Keen to get this in for PyGMT v0.4.1 too (before the ESWN workshop), but someone with a eye for detail should have another look.
michaelgrund
approved these changes
Aug 4, 2021
Member
michaelgrund
left a comment
There was a problem hiding this comment.
Looks fine to me! Great work @meghanrjones.
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…MappingTools#1407) * Add binary alias * Add nodata alias * Add find alias * Add gap alias * Add header alias * Add outcols alias * Add skiprows alias * Add wrap alias * Format * Apply suggestions from code review Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com> Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR adds the following common options to COMMON_OPTIONS in pygmt/helpers/decorators.py:
This is all the remaining common options from #48 except -l (which I would prefer having some discussion about the implementation before adding) and -: which I do not think we need to support since this can be done with
incols.The common options are added to either wiggle or blockmean/blockmedian for convenience for reviewing. I did not add the common options to all the modules that accept them because these could be good first issues for the upcoming ESWN workshop, in order to have a first exercise where everyone works on a similar task.
Relates to #48
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version