Change invalid input conditions in grdtrack#1376
Merged
Conversation
… in with no argument for newcolname
weiji14
reviewed
Jul 7, 2021
Member
weiji14
left a comment
There was a problem hiding this comment.
Thanks @willschlitzer, just one minor point.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14
approved these changes
Jul 7, 2021
michaelgrund
approved these changes
Jul 7, 2021
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
Change if statement to raise GMTInvalidInput if a DataFrame is passed in with no arguments to the newcolname parameter. Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #1344, the documentation for
grdtrackstates that an argument fornewcolnameis required for DataFrame inputs. However,GMTInvalidInputis raised if a list or numpy array is passed in. This changes the if statement to only raise the error if the input type is a DataFrame.Fixes #1344
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version