Update colorbar, inset, legend and logo baseline images for GMT 6.2.0#1322
Update colorbar, inset, legend and logo baseline images for GMT 6.2.0#1322
Conversation
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
None Image diff(s)DetailsAdded imagesModified images
Report last updated at commit 3270134 |
…6.2.0 Fix six broken tests on GMT 6.2.0 for fig.colorbar, fig.inset, fig.legend, fig.logo, and fig.plot3d.
6fbf5b7 to
1ddda56
Compare
| - md5: d08eaf4bf196c8680a3b7c0d8f4259a7 | ||
| size: 24071 |
There was a problem hiding this comment.
test_plot3d_matrix_color still failing on Windows. See https://github.com/GenericMappingTools/pygmt/pull/1322/checks?check_run_id=2756778343#step:11:486:
__________________________ test_plot3d_matrix_color ___________________________
Error: Image dimensions did not match.
Expected shape: (1040, 1729)
D:\a\pygmt\pygmt\tmp-test-dir-with-unique-name\results\pygmt.tests.test_plot3d.test_plot3d_matrix_color\baseline.png
Actual shape: (991, 1729)
D:\a\pygmt\pygmt\tmp-test-dir-with-unique-name\results\pygmt.tests.test_plot3d.test_plot3d_matrix_color\result.png
| baseline (correct) | result (wrong) |
|---|---|
 |
 |
This test is using i=[0, 1, 2, 2], so perhaps something not handled properly with the bugfixes at GenericMappingTools/gmt#5289 or GenericMappingTools/gmt#5291?
pygmt/pygmt/tests/test_plot3d.py
Lines 375 to 392 in 638adab
There was a problem hiding this comment.
But it passes on Linux and macOS. I think we can mark it as xfail on Windows, and see if @joa-quim can help debug the Windows-only issue.
There was a problem hiding this comment.
I've marked test_plot3d_matrix_color as xfail on Windows (and reverted the dvc baseline image change to that test) at 3270134.
Also revert change to test_plot3d_matrix_color.png.dvc since the baseline image works on Linux and macOS.
|
Sorry, what is it that you want me to test? |
Here is a PyGMT script: import numpy as np
import pygmt
datafile = "points.txt"
# array
data = np.loadtxt(datafile)
fig = pygmt.Figure()
fig.plot3d(
data=data,
zscale=5,
perspective=[225, 30],
region=[10, 70, -5, 10, 0, 1],
projection="X10c",
style="c0.5c",
cmap="rainbow",
frame=["a", "za"],
i=[0, 1, 2, 2],
)
fig.savefig("plot3d-array.png")The data file is points.txt. The PyGMT test shows that the above script produces the correct (left side) image on Linux/macOS, but produces the wrong (right-side) image on Windows.
It's related to recent changes about the -i option in GenericMappingTools/gmt#5289 and GenericMappingTools/gmt#5291. Please see if you can reproduce it. |
|
Ok, but I want to first reproduce this example in Julia and I'm having some errors that I need to debug first. And I'll need some remembering on how to update my PyGMT. Remember that I use the code from repo directly and my GMT win build. |
…#1322) Fix five broken tests on GMT 6.2.0 for fig.colorbar, fig.inset, fig.legend and fig.logo. Differences are mainly due to a different pen thickness setting. Also marking a test_plot3d_matrix_color as xfail on Windows due to incorrect -i parameter parsing.
…GenericMappingTools#1322) Fix five broken tests on GMT 6.2.0 for fig.colorbar, fig.inset, fig.legend and fig.logo. Differences are mainly due to a different pen thickness setting. Also marking a test_plot3d_matrix_color as xfail on Windows due to incorrect -i parameter parsing.
Description of proposed changes
Fix five broken tests on GMT 6.2.0 for fig.colorbar, fig.inset, fig.legend and fig.logo. Differences are mainly due to a different pen thickness setting. Also marking a
test_plot3d_matrix_coloras xfail on Windows due to incorrect-iparameter parsing.Addresses #1320
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version