Add a gallery example showing individual basic geometric symbols#1211
Add a gallery example showing individual basic geometric symbols#1211
Conversation
As mentioned in #1193 so far we have no gallery example in which all basic symbols are shown. This PR adds such an example to the gallery.
|
Great, the example will be very helpful. I have one question: shall we use a for loop instead of plot those symbols individually? This will make the code much shorter, e.g., the Line styles example. |
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
Also thought about that, however, with all the 14 symbols I'm not sure if this would make the code more complex to read. What do the others think about it? |
I think the current script is good. |
seisman
left a comment
There was a problem hiding this comment.
Just a few tiny suggestions. Otherwise, the PR looks good to me.
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Thanks for the review @seisman. Unfortunately, removed the units during the replcament actions. |
|
This PR looks great to me. Only one minor comment above, but it's also okay for me to not use quotes. |
…ericMappingTools#1211) Co-authored-by: Meghan Jones <meghanj@alum.mit.edu> Co-authored-by: Dongdong Tian <seisman.info@gmail.com> Co-authored-by: Yao Jiayuan <coreman.seism@gmail.com>
Description of proposed changes
As mentioned in #1193 so far we have no gallery example in which all basic symbols are shown. This PR adds such an example to the gallery.
Reminders
make formatandmake checkto make sure the code follows the style guide.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version