Migrate Figure.grdcontour tests to dvc#1158
Merged
Conversation
Related to #1131.
28 tasks
Contributor
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)Details
Report last updated at commit 6cef3e4 |
Member
|
Quick comment: |
Member
Author
Noticed that, will change it, thanks @seisman. |
seisman
reviewed
Apr 2, 2021
seisman
reviewed
Apr 2, 2021
pygmt/tests/test_grdcontour.py
Outdated
|
|
||
| @pytest.mark.mpl_image_compare | ||
| def test_grdcontour_file(): | ||
| def test_grdcontour_file(grid): |
Member
There was a problem hiding this comment.
This test check if grdcontour works for a grid file input, so shouldn't be changed to grid.
Member
Author
There was a problem hiding this comment.
Thanks! Rechanged it.
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
approved these changes
Apr 2, 2021
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Related to #1131.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version