Skip to content

Migrate Figure.meca tests to dvc#1153

Merged
seisman merged 4 commits intomasterfrom
test-meca
Apr 3, 2021
Merged

Migrate Figure.meca tests to dvc#1153
seisman merged 4 commits intomasterfrom
test-meca

Conversation

@seisman
Copy link
Member

@seisman seisman commented Apr 1, 2021 •
edited
Loading

Description of proposed changes

Related to #1131

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Apr 1, 2021
@seisman seisman added this to the 0.4.0 milestone Apr 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2021 •
edited
Loading

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
added pygmt/tests/baseline/test_meca_loc_array.png
added pygmt/tests/baseline/test_meca_spec_1d_array.png
added pygmt/tests/baseline/test_meca_spec_2d_array.png
added pygmt/tests/baseline/test_meca_spec_dataframe.png
added pygmt/tests/baseline/test_meca_spec_dict_list.png
added pygmt/tests/baseline/test_meca_spec_dictionary.png
added pygmt/tests/baseline/test_meca_spec_file.png

Image diff(s)

Details
  • pygmt/tests/baseline/test_meca_loc_array.png

  • pygmt/tests/baseline/test_meca_spec_1d_array.png

  • pygmt/tests/baseline/test_meca_spec_2d_array.png

  • pygmt/tests/baseline/test_meca_spec_dataframe.png

  • pygmt/tests/baseline/test_meca_spec_dict_list.png

  • pygmt/tests/baseline/test_meca_spec_dictionary.png

  • pygmt/tests/baseline/test_meca_spec_file.png

Report last updated at commit 5510e4e

@seisman seisman mentioned this pull request Apr 1, 2021
Closed
28 tasks
@seisman seisman requested a review from weiji14 April 1, 2021 23:02
michaelgrund
michaelgrund reviewed Apr 2, 2021
View reviewed changes
michaelgrund
michaelgrund reviewed Apr 2, 2021
View reviewed changes
michaelgrund
michaelgrund reviewed Apr 2, 2021
View reviewed changes
michaelgrund
michaelgrund reviewed Apr 2, 2021
View reviewed changes
michaelgrund
michaelgrund reviewed Apr 2, 2021
View reviewed changes
michaelgrund
michaelgrund reviewed Apr 2, 2021
View reviewed changes
@seisman @michaelgrund
Apply suggestions from code review
edfd3a5 
Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Apr 2, 2021
michaelgrund
michaelgrund approved these changes Apr 3, 2021
View reviewed changes
Copy link
Member

@michaelgrund michaelgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Apr 3, 2021
@seisman seisman merged commit 143f943 into master Apr 3, 2021
@seisman seisman deleted the test-meca branch April 3, 2021 15:03
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@seisman @michaelgrund
Migrate Figure.meca tests to dvc (GenericMappingTools#1153)
f482d0b 
Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelgrund michaelgrund michaelgrund approved these changes

@weiji14 weiji14 Awaiting requested review from weiji14

Assignees

No one assigned

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Milestone

0.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@seisman @michaelgrund