Skip to content

Migrate Figure.plot tests to dvc#1142

Merged
seisman merged 14 commits intomasterfrom
test-plot-dvc
Apr 1, 2021
Merged

Migrate Figure.plot tests to dvc#1142
seisman merged 14 commits intomasterfrom
test-plot-dvc

Conversation

@michaelgrund
Copy link
Member

@michaelgrund michaelgrund commented Mar 28, 2021 •
edited
Loading

Description of proposed changes

Changing the tests in test_plot.py to use dvc and mpl_image_compare (see #1131). Still WIP.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@michaelgrund
Migrate test_plot to dvc
9283036 
Changing the tests in test_plot.py to use dvc and mpl_image_compare. Still WIP.
@michaelgrund michaelgrund added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Mar 28, 2021
@michaelgrund michaelgrund marked this pull request as draft March 28, 2021 17:46
@seisman seisman added this to the 0.4.0 milestone Mar 28, 2021
@willschlitzer willschlitzer mentioned this pull request Mar 28, 2021
Closed
28 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2021 •
edited
Loading

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
added pygmt/tests/baseline/test_plot_colors.png
added pygmt/tests/baseline/test_plot_colors_sizes.png
added pygmt/tests/baseline/test_plot_colors_sizes_proj.png
added pygmt/tests/baseline/test_plot_datetime.png
added pygmt/tests/baseline/test_plot_from_file.png
added pygmt/tests/baseline/test_plot_lines_with_arrows.png
added pygmt/tests/baseline/test_plot_matrix.png
added pygmt/tests/baseline/test_plot_matrix_color.png
added pygmt/tests/baseline/test_plot_projection.png
added pygmt/tests/baseline/test_plot_red_circles.png
added pygmt/tests/baseline/test_plot_scalar_xy.png
added pygmt/tests/baseline/test_plot_sizes.png
added pygmt/tests/baseline/test_plot_sizes_colors_transparencies.png
added pygmt/tests/baseline/test_plot_transparency.png
added pygmt/tests/baseline/test_plot_varying_transparency.png
added pygmt/tests/baseline/test_plot_vectors.png
modified pygmt/tests/baseline/test_plot_varying_intensity.png

Image diff(s)

Details
  • pygmt/tests/baseline/test_plot_colors.png

  • pygmt/tests/baseline/test_plot_colors_sizes.png

  • pygmt/tests/baseline/test_plot_colors_sizes_proj.png

  • pygmt/tests/baseline/test_plot_datetime.png

  • pygmt/tests/baseline/test_plot_from_file.png

  • pygmt/tests/baseline/test_plot_lines_with_arrows.png

  • pygmt/tests/baseline/test_plot_matrix.png

  • pygmt/tests/baseline/test_plot_matrix_color.png

  • pygmt/tests/baseline/test_plot_projection.png

  • pygmt/tests/baseline/test_plot_red_circles.png

  • pygmt/tests/baseline/test_plot_scalar_xy.png

  • pygmt/tests/baseline/test_plot_sizes.png

  • pygmt/tests/baseline/test_plot_sizes_colors_transparencies.png

  • pygmt/tests/baseline/test_plot_transparency.png

  • pygmt/tests/baseline/test_plot_varying_transparency.png

  • pygmt/tests/baseline/test_plot_vectors.png

  • pygmt/tests/baseline/test_plot_varying_intensity.png

Report last updated at commit 7f2c0ff

@michaelgrund michaelgrund changed the title Migrate test_plot to dvc WIP: Migrate test_plot to dvc Mar 29, 2021
@michaelgrund michaelgrund marked this pull request as ready for review March 30, 2021 17:53
@michaelgrund michaelgrund requested review from seisman and weiji14 March 30, 2021 17:53
@michaelgrund michaelgrund changed the title WIP: Migrate test_plot to dvc Migrate test_plot to dvc Mar 30, 2021
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Mar 31, 2021
@seisman
Copy link
Member

seisman commented Mar 31, 2021

@michaelgrund This PR looks good. Could you please remove the blank lines between fig = Figure() and fig.plot in some tests (for example, in test_plot_projection)?

@michaelgrund
Copy link
Member Author

michaelgrund commented Mar 31, 2021

@michaelgrund This PR looks good. Could you please remove the blank lines between fig = Figure() and fig.plot in some tests (for example, in test_plot_projection)?

Done!

@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Apr 1, 2021
@seisman seisman changed the title Migrate test_plot to dvc Migrate Figure.plot tests to dvc Apr 1, 2021
@seisman seisman merged commit 819fc1d into master Apr 1, 2021
@seisman seisman deleted the test-plot-dvc branch April 1, 2021 09:18
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@michaelgrund @seisman
Migrate Figure.plot tests to dvc (GenericMappingTools#1142)
1d19ad5 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seisman seisman seisman approved these changes

@weiji14 weiji14 weiji14 approved these changes

Assignees

No one assigned

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Milestone

0.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@michaelgrund @seisman @weiji14