Update the check_figures_equal testing section in CONTRIBUTING.md #1108
Merged
Update the check_figures_equal testing section in CONTRIBUTING.md #1108
Conversation
weiji14
reviewed
Mar 23, 2021
Member
weiji14
left a comment
There was a problem hiding this comment.
Thanks @willschlitzer! Just one minor suggestion.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14
approved these changes
Mar 23, 2021
Member
weiji14
left a comment
There was a problem hiding this comment.
I'm fine with the changes, but let's leave it up for another 24 hours in case someone has an opinion on something.
seisman
approved these changes
Mar 23, 2021
maxrjones
reviewed
Mar 23, 2021
Co-authored-by: Meghan Jones <meghanj@hawaii.edu>
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…nericMappingTools#1108) Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com> Co-authored-by: Meghan Jones <meghanj@hawaii.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the
check_figures_equalnotes from the top of the testing section to below thempl_image_compareanddvcsections. It removes the note saying thatcheck_figures_equalis the preferred method of testing as it avoids committing images to the repository. It adds that usingmpl_image_compareis the preferred way of testing.Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version