Merged
Conversation
Creating a function of out grdview -T so it can be called from grdimage as well.
joa-quim
approved these changes
Mar 9, 2023
Member
joa-quim
left a comment
There was a problem hiding this comment.
No problems from the Julia side.
Contributor
|
Fantastic - thank you Paul! Just a PS: Skip nodes with NaN/NaN values transparent: |
Contributor
|
One more note: |
Member
Author
|
You could see if #7322 makes things more stable? |
Contributor
|
(Getting messy. Tell me if you want a separate issue for this.)
These do not;
|
PaulWessel
added a commit
that referenced
this pull request
Mar 12, 2023
Hoping this helps with #7315.
PaulWessel
added a commit
that referenced
this pull request
Mar 13, 2023
Hoping this helps with #7315.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is creating a function of out grdview -T so it can be called from grdimage as well as grdview. We can consider extending this to handing images (which grdimage may be fed) but for now it is like grdview -T.
Tested on @anbj script and seems to work fine - no test issues. However, need @joa-quim to try this from Julia and passing memory since it is at least possible that something different needs to be done when I call
goto basemap_and_freehe end.