Make stricter checks on central longitude#7295
Merged
PaulWessel merged 1 commit intomasterfrom Mar 5, 2023
Merged
Conversation
There are a few cases where GMT was inconsistent and wrong - we will label these as bugs: 1. When the user specified a specific central longitude, it is to be respected, and for a global map the w/e borders are set at 180 distance from that longitude. 2. If not a global map then if the distance from the specified central meridian to either border exceeds 180 then we yield a map region error. 3. If no central meridian is set then it continues to default to the mid longitude.
joa-quim
approved these changes
Mar 5, 2023
Merged
7 tasks
Member
|
The following command no longer works after this PR: |
Member
|
Before this PR was merged, the command produces the following figure. As you can see, the location of the z-axis doesn't match well with the map boundary. Is it intentional? |
Member
Author
|
Couple of issues I guess:
Probably best to improve the docs for -B on this. |
anbj
pushed a commit
that referenced
this pull request
Mar 7, 2023
There are a few cases where GMT was inconsistent and wrong - we will label these as bugs: 1. When the user specified a specific central longitude, it is to be respected, and for a global map the w/e borders are set at 180 distance from that longitude. 2. If not a global map then if the distance from the specified central meridian to either border exceeds 180 then we yield a map region error. 3. If no central meridian is set then it continues to default to the mid longitude.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few cases where GMT was inconsistent and wrong - we will label these as bugs:
-R's +ris used for rectangular areas.Tests pass and some of the odd and strange plots found in #7291 are now dealt with.