Conversation
seisman
approved these changes
Nov 21, 2022
Member
|
It seems this PR causes breaking changes: |
Member
Author
|
Lovely. Yes, I guess I should add the check that the characters following the initial valid start letter (e.g., -t) must be same case and all letters, e.g., -PNG for transparent png, -png, -tiff etc). I do not think we have a GMT module option that simply is two to four letters with those starting characters (e.g., -ps is the shortest, -tiff is longest). And next option should be a filename (e.g., -png map) and not an option. |
PaulWessel
added a commit
that referenced
this pull request
Nov 22, 2022
COntiue to see #7099. This PR adds as many further checks that we can to not get tripped up by -t15 thinking it is a bad -tiff. Has to have same case letters only.
PaulWessel
added a commit
that referenced
this pull request
Nov 22, 2022
COntiue to see #7099. This PR adds as many further checks that we can to not get tripped up by -t15 thinking it is a bad -tiff. Has to have same case letters only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7098, hopefully. Basically, if option starts with one of the first letters in a valid graphics format, has an acceptable length (<= 4) but fails to match a valid format then we assume it is a typo and report that message. E.g.,