Let -d set starting column via modifier#5966
Merged
PaulWessel merged 2 commits intomasterfrom Nov 9, 2021
Merged
Conversation
See #5630 for background discussion. The best solution is to add an optional modifier to override the default settings for the starting column, which for backwards compatible reasons shall remain 2 for input and 0 for output.
Member
|
The remaining files that need to be updated are doc/rst/source/std-opts-classic.rst and doc/rst/source/std-opts.rst. |
Member
Author
|
Seems pretty good now, no? |
maxrjones
approved these changes
Nov 9, 2021
Member
|
Ran into a problem building mbsystem due to the update to |
Member
Author
|
Thanks, will fix after breakfast
Paul Wessel, Professor
Dept. of Earth Sciences
SOEST, U of Hawaii at Manoa
…On November 10, 2021 at 5:46:08 AM, Meghan Jones ***@***.***) wrote:
Ran into a problem building mbsystem due to the update to
gmt_input_is_nan_proxy in this PR:
mbgrd2obj.c:360:46: error: too few arguments to function call, expected 3, have 2
if (gmt_input_is_nan_proxy(GMT, G->data[ij])) {
~~~~~~~~~~~~~~~~~~~~~~ ^
/Users/meghanj/Sandbox/gmt-dev/include/gmt/gmt_prototypes.h:335:17: note: 'gmt_input_is_nan_proxy' declared here
EXTERN_MSC bool gmt_input_is_nan_proxy (struct GMT_CTRL *GMT, double value, unsigned int col);
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#5966 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGJ7IX34XD45ZNN6CA3V6NLULKHUBANCNFSM5HWG333A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
PaulWessel
added a commit
that referenced
this pull request
Nov 10, 2021
See #5966 for background. Solution is to rename the function and add a backwards compatible macro in gmt_mb.h to handle this change.
PaulWessel
added a commit
that referenced
this pull request
Nov 10, 2021
* Handle deprecation of function for MB-system See #5966 for background. Solution is to rename the function and add a backwards compatible macro in gmt_mb.h to handle this change. * Update gmt_mb.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #5630 for background discussion. The best solution is to add an optional modifier +ccol to override the default settings for the starting column, which for backwards compatible reasons shall remain 2 for input and 0 for output.
All tests pass for me since the default remains the same.
Note: I don't understand how to get the modifier to show up in the options.rst file - it works in the explain*.rst_ files.