Improve the two-step grid reading when source is a matrix#3510
Merged
PaulWessel merged 11 commits intomasterfrom Jun 21, 2020
Merged
Improve the two-step grid reading when source is a matrix#3510PaulWessel merged 11 commits intomasterfrom
PaulWessel merged 11 commits intomasterfrom
Conversation
See #3408 for background. Need to add this to the repo to debug in Xcode.
Grid headers read via matrices must still remember they came from a matrix since when GMT_Read_Data is called a second time to get the data they still need to fall into that method.
Member
Author
|
I have made a few changes. First, I am parsing the full name and get the various items. For now I am only checking direction and return the object ID. I also made a small change that when we check for the validity of a given object I ignore if it has been used before (it has). I added @seisman example C code as well and two tests (with and without shading) which both passes. All other tests pass as well. There are more simplifications that can be done in gmt_api.c but I want to do that very carefully... |
Member
Author
|
Closes #3408. |
seisman
approved these changes
Jun 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
See #3408 for the initial problem. Here is what goes wrong:
Time to implement a new scheme that extracts the information directly from the filename.
Closes #3408.